Git Challenge Evaluation

Evaluation Criteria

There should be a total of three (3) commits within the applicant's repository. There should also be a set of three complete tests:

tape('should respond hello', (t) => {
  jsonist.get(urlBase, (err, body) => {
    if (err) t.error(err)

    t.equal(body.msg, 'hello')
    t.end()
  })
})

tape('should respond b64', (t) => {
  jsonist.get(`${urlBase}/b64/hello`, (err, body) => {
    if (err) t.error(err)

    t.equal(body.b64, 'aGVsbG8=')
    t.end()
  })
})

tape('should respond user-agent', (t) => {
  const opts = { headers: { 'User-Agent': 'tape' } }
  jsonist.get(`${urlBase}/user-agent`, opts, (err, body) => {
    if (err) t.error(err)

    t.equal(body.ua, 'tape')
    t.end()
  })
})

tape('cleanup', function (t) {
  server.close()
  t.end()
})

Note: if the test.js is missing any of the above, it is an immediate fail as they have misused Git rebase.

Responses

GIT-challenge is failed

no git rebase:

Thanks for attempting the challenge! Unfortunately, you did not follow directions to solve the git challenge (e.g. you didn't use git rebase correctly to add the last commit to 'master' branch). We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

overwrote previous committed code:

Thanks for attempting the challenge! Unfortunately, you did not follow directions to solve the git challenge (e.g. you overwrote your previously committed code). We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

didn't clone the repo:

Thanks for attempting the challenge! Unfortunately, you did not follow directions to solve the git challenge (e.g. you didn't clone the repo). We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

branching:

Thanks for attempting the challenge! Unfortunately, the solution is unacceptable. There should be no branching after work’s done. We can only hire people who are capable of solving such issues with no extra instructions or extra attempts.Thank you for your time and best of luck.

issues with code:

Thanks for attempting the challenge! Unfortunately, the solution is unacceptable because the code will not run. We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

no t.end()

Thanks for attempting the challenge! Unfortunately, in the test.js file a “t.end()” which declares the end of the test was deleted. That's why it never hits the ending test and keeps the connection to the server. We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

deleting commits

Thanks for attempting the challenge! Unfortunately, you've solved conflicts by deleting code from the previous commit which is unacceptable. We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

no commits

Thanks for attempting the challenge! Unfortunately, you did not follow directions to solve the git challenge. The required commits are not found on the master branch. We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.

forking the repo

Thanks for attempting the challenge! Unfortunately you forked the repo with the challenge which means your solution is disqualified. Thank you for your time and best of luck.

unrelated changes

Thanks for attempting the challenge! Unfortunately, you've added a lot of unrelated changes that are not presented in the “” commit that should not be merged. We can only hire people who are capable of solving such issues with no extra instructions or extra attempts. Thank you for your time and best of luck.